Skip to content

ast: Introduce some traits to get AST node properties generically #96924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

ast: Introduce some traits to get AST node properties generically #96924

merged 1 commit into from
May 11, 2022

Conversation

petrochenkov
Copy link
Contributor

And use them to avoid constructing some artificial Nonterminal tokens during expansion
r? @nnethercote @Aaron1011

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 10, 2022
@rust-highfive
Copy link
Contributor

Some changes occurred in src/tools/rustfmt.

cc @rust-lang/rustfmt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@nnethercote
Copy link
Contributor

Looks good, just some comment nits.

@bors delegate=petrochenkov

@bors
Copy link
Collaborator

bors commented May 11, 2022

✌️ @petrochenkov can now approve this pull request

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2022
@petrochenkov
ast: Introduce some traits to get AST node properties generically
f2b7fa4 
And use them to avoid constructing some artificial `Nonterminal` tokens during expansion
@petrochenkov
Copy link
Contributor Author

@bors r=nnethercote

@bors
Copy link
Collaborator

bors commented May 11, 2022

📌 Commit f2b7fa4 has been approved by nnethercote

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 11, 2022
@bors
Copy link
Collaborator

bors commented May 11, 2022

⌛ Testing commit f2b7fa4 with merge a85de16...

@bors
Copy link
Collaborator

bors commented May 11, 2022

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing a85de16 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2022
@bors bors merged commit a85de16 into rust-lang:master May 11, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 11, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a85de16): comparison url.

Summary:

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 0 1 0
mean2 N/A N/A N/A -0.2% N/A
max N/A N/A N/A -0.2% N/A

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@petrochenkov petrochenkov deleted the nonon branch February 22, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote left review comments

Assignees

@nnethercote nnethercote

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @rust-highfive @nnethercote @bors @rust-timer @rustbot